chore: remove "password" input in kong/license step of workflows #5316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/7162394343 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5316 +/- ##
=======================================
- Coverage 75.9% 75.8% -0.1%
=======================================
Files 170 170
Lines 19447 19447
=======================================
- Hits 14767 14751 -16
- Misses 3851 3864 +13
- Partials 829 832 +3 ☔ View full report in Codecov by Sentry. |
tao12345666333
approved these changes
Dec 11, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.12.x release/2.12.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.12.x
# Create a new branch
git switch --create backport-5316-to-release/2.12.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 77527ee81e175e5a0860c0f1a29c09df1c6388f3
# Push it to GitHub
git push --set-upstream origin backport-5316-to-release/2.12.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.12.xThen, create a pull request where the |
tao12345666333
pushed a commit
that referenced
this pull request
Dec 15, 2023
(cherry picked from commit 77527ee)
tao12345666333
pushed a commit
that referenced
this pull request
Dec 15, 2023
(cherry picked from commit 77527ee)
randmonkey
added a commit
that referenced
this pull request
Dec 15, 2023
* chore(gha): preemptively add 1p creds (cherry picked from commit e84786e) * chore: remove "password" input in kong/license step of workflows (#5316) (cherry picked from commit 77527ee) --------- Co-authored-by: Isa Farnik <[email protected]> Co-authored-by: Tao Yi <[email protected]>
tao12345666333
pushed a commit
that referenced
this pull request
Jan 10, 2024
randmonkey
added a commit
that referenced
this pull request
Jan 10, 2024
…5414) * fix(manager) restore InitCacheSyncDuration (#5238) Fix regression that removed initial cache sync delay. Add --init-cache-sync-duration flag to override the delay period. --------- Co-authored-by: Travis Raines <[email protected]> (cherry picked from commit 1737253) * chore(gha): preemptively add 1p creds * chore: remove "password" input in kong/license step of workflows (#5316) --------- Co-authored-by: Jonah Back <[email protected]> Co-authored-by: Isa Farnik <[email protected]> Co-authored-by: Tao Yi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upstream action
Kong/kong-licensehas deprecated the inputpasswordand produces warnings if it is present. We should remove the input in calling the action.Which issue this PR fixes:
--
Special notes for your reviewer:
May need to be backported to
2.12.xbecause we need run tests against KIC 2.12 LTS on this branch.PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR